Skip to content

Conversation

@namsonx
Copy link
Collaborator

@namsonx namsonx commented Nov 4, 2022

No description provided.

Copy link
Collaborator

@HolQue HolQue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Son,

please find my comments as sticky notes in attached JsonPreprocessor_reviewed_QT.pdf
JsonPreprocessor_reviewed_QT.pdf


Then go to python-jsonpreprocessor, using the 2 common commands below to build or install this package:

.. code-block::
Copy link
Owner

@test-fullautomation test-fullautomation Nov 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Son,
we don't need to write here the help for the build command.
The chapter "how to install" should be like e.g. here: https://github.com/test-fullautomation/robotframework-testresultwebapptool
Thank you,
Thomas

@test-fullautomation
Copy link
Owner

Hi Son,
thank you for your pull request.
Please refer to my comments.
Thank you,
Thomas

@test-fullautomation test-fullautomation added 0.6.0 documentation Improvements or additions to documentation labels Nov 4, 2022
@test-fullautomation test-fullautomation added this to the 0.6.0.0 Win10 milestone Nov 4, 2022
@test-fullautomation
Copy link
Owner

Hi Son,
by when do I get an update here?
Thank you,
Thomas

Copy link
Owner

@test-fullautomation test-fullautomation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Son,
looks O.K. for me!
Thank you,
Thomas

@test-fullautomation test-fullautomation merged commit c373bc0 into develop Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.6.0 documentation Improvements or additions to documentation

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants